Update iana-types.json #295
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add 'dcm' extension to application/dicom mime
|
@DimitriPapadopoulos How long does it take to approve the pull request? |
dougwilson
suggested changes
Aug 3, 2023
There was a problem hiding this comment.
Hello, and thank you for your contribution. Unfortunately the file you changed is a generated file and your changes would be overridden. Please see our contribution instructions at https://github.com/jshttp/mime-db#direct-inclusion
|
Sorry, I thought I already commented on it, but apparently I never submitted the comment. The PR needs to be updated to change a non generated file. |
|
@dougwilson So #287 is the correct fix after all, with Shouldn't the IANA database be fixed upstream? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add 'dcm' extension to application/dicom mime. 'dcm' is the recommended extension for this multimedia type as stated at point 2 of additional information in this iana.org page https://www.iana.org/assignments/media-types/application/dicom.